git: 9front

Info  •  Files  •  Log  •  Branches

devmouse: fix openmode() handling

openmode() can raise error with invalid mode passed, but we already
incremented the exclusive mouse refcount at that point! call openmode()
early to avoid this.

--- a/sys/src/9/port/devmouse.c

+++ b/sys/src/9/port/devmouse.c

@@ -170,6 +170,9 @@

 static Chan*

 mouseopen(Chan *c, int omode)

 {

+	int mode;

+

+	mode = openmode(omode);

 	switch((ulong)c->qid.path){

 	case Qdir:

 		if(omode != OREAD)

@@ -193,7 +196,7 @@

 	default:

 		incref(&mouse);

 	}

-	c->mode = openmode(omode);

+	c->mode = mode;

 	c->flag |= COPEN;

 	c->offset = 0;

 	return c;

-- 

⑨