git: 9front

Info  •  Files  •  Log  •  Branches

kernel: eliminate goto in dupseg() (bikeshedding)

Just merge the "sameseg: label" case into the switch
and let the cases fall into it, avoiding the goto.

--- a/sys/src/9/port/segment.c

+++ b/sys/src/9/port/segment.c

@@ -248,7 +248,11 @@

 	case SG_FIXED:

 	case SG_STICKY:

 	default:

-		goto sameseg;

+	sameseg:

+		incref(s);

+		qunlock(s);

+		poperror();

+		return s;

 	case SG_STACK:

 		n = newseg(s->type, s->base, s->size);

@@ -296,12 +300,6 @@

 	qunlock(s);

 	poperror();

 	return n;

-

-sameseg:

-	incref(s);

-	qunlock(s);

-	poperror();

-	return s;

 }

 /*

-- 

⑨