code: plan9front

Info  •  Files  •  Log

acme: fix use after free in warning() call (thanks igor)

--- a/sys/src/cmd/acme/wind.c

+++ b/sys/src/cmd/acme/wind.c

@@ -610,13 +610,14 @@

 		r = runerealloc(r, n+1);

 		r[n] = 0;

 	}

-	free(a);

 	if((d->qid.type&QTDIR) == 0){

 		free(d);

 		warning(nil, "%s: not a directory\n", a);

 		free(r);

+		free(a);

 		return;

 	}

+	free(a);

 	free(d);

 	w->nincl++;

 	w->incl = realloc(w->incl, w->nincl*sizeof(Rune*));