code: plan9front

Info  •  Files  •  Log

devip: Fix transfoward() iphash collision

We falsely confused locally listening connections
as existing translation entires. Fix it.

--- a/sys/src/9/ip/ipaux.c

+++ b/sys/src/9/ip/ipaux.c

@@ -426,10 +426,14 @@

 	/* Translation already exists? */

 	iph = iphtlook(ht, sa, sp, da, dp);

-	if(iph != nil) {

-		if(iph->trans != 1)

+	if(iph != nil){

+		if(iph->trans == 1)

+			return transupdate(p, iphforward(iph));

+		if(iph->match == IPmatchexact){

+			netlog(p->f, Logtrans, "trans: backwards collision: %s!%I!%d -> %I!%d\n",

+				p->name, sa, sp, da, dp);

 			return nil;

-		return transupdate(p, iphforward(iph));

+		}

 	}

 	/* Bad source address? */