shithub: drawterm

Download patch

ref: c824c4972fe1a772e239406e148a5327e872bf54
parent: 61ee60d7237b285d36ad0130fbb7caf7fca7804a
author: Sigrid Solveig Haflínudóttir <ftrvxmtrx@gmail.com>
date: Tue Nov 9 18:11:09 EST 2021

factotum: fix a memory leak

--- a/posix-factotum.c	Mon Nov  8 20:55:47 2021
+++ b/posix-factotum.c	Tue Nov  9 18:11:09 2021
@@ -83,24 +83,28 @@
 	name = smprint("%s/factotum", getns());
 
 	if(name == nil || access(name, 0) < 0)
-		return -1;
+		goto err;
 	memset(&su, 0, sizeof su);
 	su.sun_family = AF_UNIX;
 	if(strlen(name)+1 > sizeof su.sun_path){
 		werrstr("socket name too long");
-		return -1;
+		goto err;
 	}
 	strcpy(su.sun_path, name);
 	if((fd = socket(AF_UNIX, SOCK_STREAM, 0)) < 0){
 		werrstr("socket: %r");
-		return -1;
+		goto err;
 	}
 	if(connect(fd, (struct sockaddr*)&su, sizeof su) < 0){
 		werrstr("connect %s: %r", name);
 		close(fd);
-		return -1;
+		goto err;
 	}
 
+	free(name);
 	return lfdfd(fd);
+err:
+	free(name);
+	return -1;
 }