code: plan9front

Download patch

ref: b2518fd92a29c1b7987447d46ebe25a16433d3a9
parent: 17f7f6be4e1a316c0f5f26ff70e047aece4de2bc
author: Ori Bernstein <ori@eigenstate.org>
date: Sun May 19 20:38:55 EDT 2024

fs: correct mode check for other group

we copied and pasted the structure of this from
cwfs, but they lay out the bits differently. We
fixed this for the other cases, but forgot this
one, which lead to exec being permitted when it
shouldn't have been.

--- a/sys/src/cmd/gefs/fs.c
+++ b/sys/src/cmd/gefs/fs.c
@@ -1068,7 +1068,7 @@
 			if((m & (fmode>>3)) == m)
 				return 0;
 	}
-	if(m & fmode) {
+	if((m & fmode) == m) {
 		if((fmode & DMDIR) && (m == DMEXEC))
 			return 0;
 		if(!ingroup(f->uid, nogroupid))