git: plan9front

Info  •  Files  •  Log  •  Branches

upas/Mail: don't move cursor when flags are unchanged

when doing bulk operations one after the other, like
mass-marking messages read, the cursor tends to jump
to update the messages, but they're already in the
right state; don't do that.

--- a/sys/src/cmd/upas/Mail/mbox.c

+++ b/sys/src/cmd/upas/Mail/mbox.c

@@ -313,11 +313,13 @@

 {

 	Mesg *m;

 	char *f;

+	int old;

 	if((m = mesglookup(name, digest)) == nil)

 		return nil;

 	if((f = rslurp(m, "flags", nil)) == nil)

 		return nil;

+	old = m->flags;

 	free(m->mflags);

 	m->mflags = f;

 	m->flags &= ~(Fdel|Fseen|Fresp);

@@ -324,6 +326,8 @@

 	if(strchr(m->mflags, 'd')) m->flags |= Fdel;

 	if(strchr(m->mflags, 's')) m->flags |= Fseen;

 	if(strchr(m->mflags, 'a')) m->flags |= Fresp;

+	if(old == m->flags)

+		return nil;

 	return m;

 }

-- 

⑨